Home Explore Help
Register Sign In
chenxixian
/
devdocs
mirror of https://github.com/freeCodeCamp/devdocs
1
0
Fork 0
Files Issues 0 Wiki
Browse Source

Fix app cache not updating when changing the app's color theme

This is needed because the index page is part of the app cache, and the <html> tag has a different class depending on the theme.
Thibaut Courouble 7 years ago
parent
d72de330aa
commit
e8d52c9cfd
3 changed files with 15 additions and 1 deletions
Unified View Show Diff Stats
  1. 1 0
      assets/javascripts/views/content/settings_page.coffee
  2. 13 0
      test/app_test.rb
  3. 1 1
      views/manifest.erb

+ 1 - 0
assets/javascripts/views/content/settings_page.coffee
View File 

@@ -28,6 +28,7 @@ class app.views.SettingsPage extends app.View
 
     html.classList.toggle('_theme-default')
 
     html.classList.toggle('_theme-default')
 
     html.classList.toggle('_theme-dark')
 
     html.classList.toggle('_theme-dark')
 
     app.settings.set('dark', !!enable)
 
     app.settings.set('dark', !!enable)
 
+    app.appCache?.updateInBackground()
 
     return
 
     return
 
 
 
   toggleLayout: (layout, enable) ->
 
   toggleLayout: (layout, enable) ->

+ 13 - 0
test/app_test.rb
View File 

@@ -122,6 +122,19 @@ class AppTest < MiniTest::Spec
 
       refute_includes last_response.body, 'foo'
 
       refute_includes last_response.body, 'foo'
 
     end
 
     end
 
 
 
+    it "has the word 'default' when no 'dark' cookie is set" do
 
+      get '/manifest.appcache'
 
+      assert_includes last_response.body, '# default'
 
+      refute_includes last_response.body, '# dark'
 
+    end
 
+
 
+    it "has the word 'dark' when the cookie is set" do
 
+      set_cookie('dark=1')
 
+      get '/manifest.appcache'
 
+      assert_includes last_response.body, '# dark'
 
+      refute_includes last_response.body, '# default'
 
+    end
 
+
 
     it "sets default size" do
 
     it "sets default size" do
 
       get '/manifest.appcache'
 
       get '/manifest.appcache'
 
       assert_includes last_response.body, '20rem'
 
       assert_includes last_response.body, '20rem'

+ 1 - 1
views/manifest.erb
View File 

@@ -1,5 +1,5 @@
 
 CACHE MANIFEST
 
 CACHE MANIFEST
 
-# <%= app_size %> <%= app_layout %>
 
+# <%= app_theme %> <%= app_size %> <%= app_layout %>
 
 
 
 CACHE:
 
 CACHE:
 
 /
 
 /